-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow sidecar to manage network interface #128
Conversation
Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
@hown3d Thank you for your contribution. |
Thank you @hown3d for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing a way forward with regards to the cilium issue.
It is interesting how history seems to repeat itself as the apiserver-proxy at some time in the past used to create devices...
b7586b1
to
8fb04c3
Compare
Signed-off-by: Lukas Hoehl <[email protected]>
8fb04c3
to
ad06cbc
Compare
Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
/lgtm |
/lgtm |
What this PR does / why we need it:
This PR adds a flag
manage-interface
to the apiserver-proxy sidecar.The g/g deploys the sidecar to add the kube-apiserver endpoint IP to the
lo
loopback device:https://github.com/gardener/gardener/blob/726d9cf849807ae7e8b9f2c0362f8ee6570a1951/pkg/component/networking/apiserverproxy/apiserver_proxy.go#L307
With this flag we are able to mitigate this cilium issue, since we can choose an interface name that's picked up by cilium.
E.g. using
dummy0
as interface nameRelease note: