garden: add support for custom shell commands #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garden.shell can not be configured to arbitrary interpreter commands. We now run the value through the "shlex" parser to separate the string into individual command-line arguments. Shorthand shell values are still supported and special-cased. Only when the command string expands to a command with multiple arguments we treat the command like a custom shell and disable the internal builtin arguments.
Allow the interactive shell to be configured separately via the "garden.interactive-shell" configuration value. This allows custom commands to be configured in "garden.shell" that take command strings while specifying an interactive shell command via "garden.interactive-shell".
use the current tree for "garden shell" when nothing is specified. This makes it easier to start a shell in the current directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
garden.shell can not be configured to arbitrary interpreter commands.
We now run the value through the "shlex" parser to separate the
string into individual command-line arguments.
Shorthand shell values are still supported and special-cased.
Only when the command string expands to a command with multiple
arguments we treat the command like a custom shell and
disable the internal builtin arguments.