Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create jazz-crypto-rs package #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Create jazz-crypto-rs package #1

wants to merge 13 commits into from

Conversation

bensleveritt
Copy link
Collaborator

Ports much of the external WASMCrypto dependancies to our own crypto rust lib, allowing treeshaking and reducing the crossing of the WASM boundary.

Particularly @hazae41/berith (x25519 and ed25519) and hash-wasm (blake3)

@bensleveritt bensleveritt requested review from aeplay and gdorsi January 30, 2025 16:15
@bensleveritt bensleveritt mentioned this pull request Jan 30, 2025
Open
aeplay
aeplay requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@aeplay aeplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure bliss, just a couple small nitpicks and the incremental hashing change we talked about!

src/crypto/ed25519.rs Outdated Show resolved Hide resolved
src/crypto/sign.rs Outdated Show resolved Hide resolved
src/hash/blake3.rs Outdated Show resolved Hide resolved
@bensleveritt bensleveritt requested a review from aeplay February 3, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdorsi gdorsi Awaiting requested review from gdorsi

@aeplay aeplay Awaiting requested review from aeplay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensleveritt @aeplay