This is a continuation of #5577 removing more unused function arguments #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems this needs a rebase now |
I'd like to update the description of the function, but I have no idea what it does.
This function isn't used anywhere in the GAP library, or anywhere in the gap-4.12.2 archive.
The extra arguments were added in 1d7361e in 2013, and removed again now.
This function isn't used anywhere else in the GAP library, or anywhere else in the gap-4.12.2 archive.
This function isn't used anywhere else in the GAP library, or anywhere else in the gap-4.12.2 archive.
This function isn't used anywhere else in the GAP library, or anywhere else in the gap-4.12.2 archive.
james-d-mitchell
force-pushed
the
unused-func-args-2
branch
from
6068474
to
8e3f9f4
Compare
|
@fingolfin rebased, and ready for review. |
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of further cleanups arising from analyse functions with unused arguments. Again probably best viewed commit by commit.