Fix 'browser' help viewer for Windows #5515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we maybe have a file of manual tests? We would obviously want to minimize them, but I have no idea how to test if this is working. |
fingolfin
reviewed
Oct 11, 2023
| @@ -65,28 +65,26 @@ show := PagerAsHelpViewer, | |||
| ); | |||
|
|
|||
|
|
|||
| if ARCH_IS_WINDOWS() then | |||
There was a problem hiding this comment.
Instead of unconditionally defining the code below, could we perhaps have a ARCH_IS_CYGWIN or so which does return true here?
There was a problem hiding this comment.
Ah, forgot that such check exists. Makes perfect sense!
|
@olexandr-konovalov do you have any plans to update this? If you could indicate how to test it, then perhaps @ChrisJefferson could do so |
|
This PR has known issues and got no updates or even replies in 4 months -> closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported to me that "browser" help viewer is not available on Windows. It happens because ARCH_IS_WINDOWS() no longer returns 'true'. Furthemore, 'start' is also not available, so I have put back some code removed in #603. Now this works.