Add contents of pkg-ci-scripts to this composite action
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Sorry, I didn't notice this PR before :-(.
Looks good to me, some minor remarks/questions, all optional.
Perhaps you could also review gap-actions/process-coverage#7 (and/or improve upon it, whatever)?
| run: | | ||
| # build some packages; default is to build 'io' and 'profiling', in order to | ||
| # generate coverage results. | ||
| # Handle GAP_PKGS_TO_BUILD default value | ||
| if [ "${{inputs.GAP_PKGS_TO_BUILD}}" = "default" ]; |
There was a problem hiding this comment.
I know this is old code so not in scope for this PR, but perhaps you know: is the value "default" really ever used? I thought that not specifying it would set it to the value we specified as default, i.e., io profiling?
There was a problem hiding this comment.
I don't really know, the whole "default" thing was @ssiccha's idea and work. I never use it, anyway.
wilfwilson
force-pushed
the
add-pkg-ci-content
branch
from
0409079
to
28c1e0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of work to address #25.
So far, I have copied the contents of
pkg-ci-scripts/build_gap.shinto the action, but I have kept cloning thepkg-ci-scriptsrepo, because it is still used by the other actions.This could be merged, modulo suggestions from reviews, or it could wait until the other actions are similarly updated.