Skip to content

Commit

Permalink
Support dot in the additional information of the PFC watchdog event i…
Browse files Browse the repository at this point in the history
…n the yang model (sonic-net#18235)

### Why I did it

Support dot (`.`) in the `additional_info` field in the PFC watchdog event in the yang model.

The `additional_info` field was introduced to represent diagnosis information when a PFC storm is detected, which can include fragments.

Signed-off-by: Stephen Sun <[email protected]>

### How I did it

#### How to verify it

Unit test.
  • Loading branch information
stephenxs authored Mar 15, 2024
1 parent a53cbdc commit a333309
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@
"SONIC_EVENTS_SWSS_PFC_STORM_VALID_WITH_ADDITIONAL_INFO": {
"desc": "VALID IF_STATE EVENT."
},
"SONIC_EVENTS_SWSS_PFC_STORM_VALID_WITH_ADDITIONAL_INFO_FRAGMENT": {
"desc": "VALID IF_STATE EVENT."
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_1": {
"desc": "PFC_STORM_EVENT_INCORRECT_ADDITIONAL_INFO failure.",
"eStrKey": "Pattern"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,18 @@
}
}
},
"SONIC_EVENTS_SWSS_PFC_STORM_VALID_WITH_ADDITIONAL_INFO_FRAGMENT": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:pfc-storm": {
"ifname": "Ethernet0",
"queue_index": 0,
"queue_id": 0,
"port_id": 0,
"additional_info": "info1:1.2|info2:3.25",
"timestamp": "1985-04-12T23:20:50.52Z"
}
}
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_1": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:pfc-storm": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-yang-models/yang-models/sonic-events-swss.yang
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ module sonic-events-swss {

leaf additional_info {
type string {
pattern '[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+(\|{1}[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+)*';
pattern '[-a-zA-Z0-9_]+:[-a-zA-Z0-9_.]+(\|{1}[-a-zA-Z0-9_]+:[-a-zA-Z0-9_.]+)*';
}
description "Additional information to investigate PFC storm";
}
Expand Down

0 comments on commit a333309

Please sign in to comment.