Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt recipes for LTS v1.0.2 #21

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

Astro-Kirsty
Copy link
Member

@Astro-Kirsty Astro-Kirsty commented Jun 11, 2024

I made adaptions to mcmc and the dark-matter notebooks to work for LTS v1.0.2

I also updated the env files.

Resolves #13

Resolves gammapy/gammapy#4351

Signed-off-by: Astro-Kirsty <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Astro-Kirsty
Copy link
Member Author

I also wonder if it is worth still having the dark matter recipe because this information is now available in a tutorial
https://docs.gammapy.org/1.2/tutorials/api/astro_dark_matter.html

@registerrier
Copy link
Contributor

Thanks @Astro-Kirsty !

Have you checked whether the notebooks run fine? I had noticed some time ago that the interactive edition was not running at all.

@registerrier
Copy link
Contributor

To clean the notebooks (black and strip, you can use the scripts here:

from utils import notebook_black, notebook_strip

notebook_black(path_to_notebook)
notebook_strip(path_to_notebook)

Signed-off-by: Astro-Kirsty <[email protected]>
Copy link
Member

@bkhelifi bkhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Astro-Kirsty! It looks good for me, beyond the Régis's comments

@Astro-Kirsty
Copy link
Member Author

@registerrier, I just had to adapt the version of jupyter-lab to ensure it works correctly.
All is good now

@registerrier
Copy link
Contributor

@registerrier, I just had to adapt the version of jupyter-lab to ensure it works correctly. All is good now

Thanks @Astro-Kirsty. qgrid is apparently no longer maintained, hence the constraint on jupyterlab. I think a possible further update of this PR (for a later PR of course) could be to look into more recent solutions such as ipyautui

Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Astro-Kirsty

@registerrier registerrier merged commit 9a2a3ad into gammapy:master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update recipes to v1.0 DarkMatter docs wrong
3 participants