-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt recipes for LTS v1.0.2 #21
Conversation
Signed-off-by: Astro-Kirsty <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I also wonder if it is worth still having the dark matter recipe because this information is now available in a tutorial |
Thanks @Astro-Kirsty ! Have you checked whether the notebooks run fine? I had noticed some time ago that the interactive edition was not running at all. |
To clean the notebooks (black and strip, you can use the scripts here:
|
Signed-off-by: Astro-Kirsty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty! It looks good for me, beyond the Régis's comments
Signed-off-by: Astro-Kirsty <[email protected]>
@registerrier, I just had to adapt the version of jupyter-lab to ensure it works correctly. |
Thanks @Astro-Kirsty. qgrid is apparently no longer maintained, hence the constraint on jupyterlab. I think a possible further update of this PR (for a later PR of course) could be to look into more recent solutions such as ipyautui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty
I made adaptions to mcmc and the dark-matter notebooks to work for LTS v1.0.2
I also updated the env files.
Resolves #13
Resolves gammapy/gammapy#4351