-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bump image version from 2 to 3 in Ubuntu #67
Conversation
Changes - Bump image version in the ubuntu
I just realized that it worth to specify image version number from params instead like it is achieved in forked repo here but not sure what changes should be made |
@GabLeRoux how come the version published on CircleCI repo does not reflect the change from 2->3 for Ubuntu docker images? |
I think we need to create a new release for it. By digging slightly deeper, I've found some issues related to activation as well. I'll see what I can do. I think the plan should look as follows:
edit: Created a hotfix to reference working script: https://github.com/game-ci/unity-orb/releases/tag/v1.7.1 I'll try to do this for the next few hours, this should help us unblock the orb usage. Also note that the dependency on the gitlab project is not the best thing ever, but I'll make sure to document it. We had some discussions about creating some kind of cli or shared logic to ease the maintenance of several tools using our build tools, this would be ideal, but in the meantime, I'm sure we can get this orb back on track. A simple solution would probably be to host a copy of the You can subscribe to the releases of this project so you should get notified when there's something to test: On project's home page: Watch > Custom Then check Releases: |
Wow, that's what I call an answer :D Thanks for the detailed help. I've subscribed to the releases. Good news is I've found out that I'm not an idiot, and my CircleCI pipeline was failing for a valid reason not of my own doing. Bad news is I've spent 4 hrs to notice this and convince myself :) Looking forward to that release. |
I've updated above comment with the plan that is currently in progress. |
@GabLeRoux any chance of getting that update on the public Orb so we can move on with our CI/CD pipeline? |
I’ve created a hotfix release for the GitLab CI project update (v1.7.1), but it doesn't include the changes from PR #83. We're close to a working solution, but we need to do some testing before getting to a stable release. To publish a new orb version, we need the tests to pass in the main repository. I’ve done the hotfix version as described in #87, but it'd be best to get the tests passing before moving forward. Right now, we need to get the tests for PR #83 to work. Here’s the status:
Edit: the tests had time to pass while I was writing this message 🎉 The PR #83 seems ready to merge (tests are passing 🚀), but it would be great if people could test it too. Also, extracting the serial from the Unity license isn’t ideal, but it works. If we go forward with this, we'll need to update some documentation. If you'd like to give it a try here's an untested draft based on what I've found in the ReadMe of the project: #!/bin/bash
# Set variables
ORG_ID="<your-organization-id>" # Replace with your CircleCI organization ID
NAMESPACE="<my-namespace>" # Replace with your desired namespace
ORB_NAME="<my-orb-name>" # Replace with your desired orb name
REPO_URL="[email protected]:game-ci/unity-orb.git"
BRANCH_NAME="feature/refactor-orb-activation-to-serial"
# Clone the Unity Orb repository and checkout the feature branch
git clone $REPO_URL
cd unity-orb
git checkout $BRANCH_NAME
# Create the namespace on CircleCI
echo "Creating CircleCI namespace..."
circleci namespace create $NAMESPACE --org-id $ORG_ID
# Create the orb in the specified namespace
echo "Creating CircleCI orb..."
circleci orb create $NAMESPACE/$ORB_NAME --private
# Pack the orb from the src directory
echo "Packing the orb..."
circleci orb pack src > unity-orb.yml
# Publish the orb to CircleCI with version `dev:$BRANCH_NAME`
echo "Publishing the orb..."
circleci orb publish unity-orb.yml $NAMESPACE/$ORB_NAME@dev:$BRANCH_NAME
# Promote the orb to a patch version
# echo "Promoting the orb..."
# circleci orb publish promote $NAMESPACE/$ORB_NAME@dev:$BRANCH_NAME patch
echo "Orb has been created, packed, published, and promoted successfully!" I plan to improve these instructions once I have some time to test them with #80 |
Changes
Checklist
Additional changes still need
The orb needs to clarify which image versions or Docker repo versions are supported in circle ci otherwise developers may stuck when getting this error in more latest versions of unity editor:
The issue is discussed more in details here #64