Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Icon Library #3317

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feat: Icon Library #3317

wants to merge 10 commits into from

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Sep 17, 2024

resolves #3316

Copy link

github-actions bot commented Sep 17, 2024

🤖 Pull request artifacts

file commit
pr3317-stackable-3317-merge.zip b53b3ff

github-actions bot added a commit that referenced this pull request Sep 17, 2024
github-actions bot added a commit that referenced this pull request Sep 18, 2024
github-actions bot added a commit that referenced this pull request Sep 18, 2024
github-actions bot added a commit that referenced this pull request Oct 7, 2024
github-actions bot added a commit that referenced this pull request Oct 7, 2024
github-actions bot added a commit that referenced this pull request Oct 8, 2024
@bfintal
Copy link
Contributor

bfintal commented Oct 8, 2024

Change Requests:

  1. Let's change the "Icon Settings" in the icon picker popup into a "Library" icon, then when clicked, it should open the Icon Library in the sidebar

In the icon picker in the icon library

image Screenshot 2024-10-08 at 8 17 20 PM
  1. See above image as reference, change the popover to only have:
  • Drop icon similar to the screenshot above
  • Mid aligned text that says: "Drag an SVG icon here or click the button below upload one"
  • Button that says "Upload SVG"
  1. Dragging an SVG icon should make the popover look/behave the same way as the normal icon popover when dragging on

When clicking the plus button in the icon library

  1. Change the popover to the same popover mentioned above

src/components/icon-search-popover/index.js Outdated Show resolved Hide resolved
src/components/icon-search-popover/index.js Outdated Show resolved Hide resolved
github-actions bot added a commit that referenced this pull request Oct 9, 2024
github-actions bot added a commit that referenced this pull request Oct 28, 2024
prevent frequent api calls when changing item names
github-actions bot added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature: Icon Library
2 participants