Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused/outdated common_toolset and flip all install_resolver_dependencies to false #608

Merged
merged 2 commits into from
May 17, 2023

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented May 17, 2023

We never want to install resolver dependencies, although currently the CI script prevents this anyway regardless of the lock file values since it explicitly passes --skip_install_resolver_dependencies due to galaxyproject/ephemeris#181, but at some point if the fix is merged we'd want to remove that.

Installation sequence for tool-installers

  • Test using @galaxybot test this
  • Inspect CI output for expected changes
  • Deploy using @galaxybot deploy this if test install was successful
  • Merge this PR

@natefoo natefoo requested a review from a team as a code owner May 17, 2023 18:38
@natefoo
Copy link
Member Author

natefoo commented May 17, 2023

The test failure is expected in this case.

@natefoo natefoo added the meta Unrelated to tool installation label May 17, 2023
@natefoo natefoo merged commit baf6f77 into galaxyproject:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Unrelated to tool installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant