Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate operations from the Notification API #472

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Integrate operations from the Notification API #472

wants to merge 44 commits into from

Conversation

heisner-tillman
Copy link

@heisner-tillman heisner-tillman commented Jun 6, 2023 •
edited
Loading

This is a part of #471

Summary

  • Add all operations
  • Add tests for all operations
  • Add NotificationClient to GalaxyClient
  • Update the template_galaxy.yml and template_galaxy.ini to enable notifications for testing

How to test the changes

Run the corresponding test file:
bioblend/_tests/TestGalaxyNotifications.py

@heisner-tillman heisner-tillman changed the title Integrate get_notification_status operation from the Notification API Integrate operations from the Notification API Jun 27, 2023
@bgruening bgruening requested a review from nsoranzo July 1, 2023 07:10
bernt-matthias
bernt-matthias reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to rebase? Maybe this solves the test problems.

bioblend/_tests/TestGalaxyNotifications.py Outdated Show resolved Hide resolved
bioblend/galaxy/notifications/__init__.py Outdated Show resolved Hide resolved
bioblend/_tests/template_galaxy.ini Outdated Show resolved Hide resolved
@heisner-tillman
Copy link
Author

heisner-tillman commented Aug 29, 2023 •
edited
Loading

try to rebase

Done.

@bernt-matthias
Copy link
Contributor

Tests fail. Guess you need to add typing-extensions to

bioblend/setup.cfg

Line 69 in fe48906

install_requires =

@bgruening
Copy link
Member

Green! 🍏

nsoranzo
nsoranzo reviewed Oct 6, 2023
View reviewed changes
bioblend/galaxyclient.py Outdated Show resolved Hide resolved
nsoranzo
nsoranzo reviewed Oct 6, 2023
View reviewed changes
bioblend/galaxy/notifications/__init__.py Show resolved Hide resolved
bioblend/galaxy/notifications/__init__.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@heisner-tillman
Add NotificationClient to GalaxyClient
c9e72af
@heisner-tillman
Create NotificationClient including get_notification_status operation
c0675b2
@heisner-tillman
Create testfile for NotificationClient with test for get_notification…
aeb0fce 
…_status operation
@heisner-tillman
Update the template_galaxy.yml and template_galaxy.ini to enable noti…
030d40e 
…fications for testing
@heisner-tillman
Rewrite docstring of the get_notification_status method to improve do…
0fe632c 
…cumentation
@heisner-tillman
Refactor test for get_notification_status operation
06d845d
@heisner-tillman
Refactor get_notification_status operation for easier use
ab0589a
@heisner-tillman
Refactor test for get_notification_status operation for a more compre…
6afa981 
…hensive test
@heisner-tillman
Refactor get_notifications_status operation
05877a0
@heisner-tillman
Refactor test for get_notifications_status
79a1c29
@heisner-tillman
Remove unused type hints
b2b84ef
@heisner-tillman
Add get_notification_preferences operation
4db1456
@heisner-tillman
Add update_notification_preferences operation
cc85fad
@heisner-tillman
Add test for get_notification_preferences and update_notification_pre…
8f9eb52 
…ferences operation
@heisner-tillman
Add broadcast_notification operation
c7f820a
@heisner-tillman
Add send_notification operation
711f730
@heisner-tillman
Add helper functions for testing
1a23055
heisner-tillman and others added 26 commits March 28, 2024 12:21
@heisner-tillman
Add test for send_notification, broadcast_notification and get_notifi…
85492c9 
…cation_status operation
@heisner-tillman
Fix typing hint
c1a5459
@heisner-tillman
Add get_user_notifications operation
f2cc583
@heisner-tillman
Add test for get_user_notifications operation
d3696bc
@heisner-tillman
Add show_notification operation
856da96
@heisner-tillman
Add test for show_notification operation
63ba9d6
@heisner-tillman
Add update_user_notification and update_user_notifications operation
8915b10
@heisner-tillman
Add 204 as accepted reponse in put request
1f00d0e
@heisner-tillman
Add test for update_user_notification and update_user_notifications o…
18aa514 
…peration
@heisner-tillman
Add get_broadcasted and update_broadcasted_notification operations
823a138
@heisner-tillman
Add test for get_broadcasted and update_broadcasted_notification oper…
70fc218 
…ations
@heisner-tillman
Add test for get_broadcasted operation
dfd13cf
@heisner-tillman
Add get_all_broadcasted operations
be5458b
@heisner-tillman
Add test for get_all_broadcasted operations
4ec0f6b
@heisner-tillman
Add delete_notification and delete_notifications operation
e97d9e4
@heisner-tillman
Add test for delete_notification and delete_notifications operation
5ae6f63
@heisner-tillman
Add docstring to indicate what galaxy version is required to run the …
e6e4ca7 
…class
@heisner-tillman
Remove wrong parameter in docstring
9930b70
@heisner-tillman
Refactor type assignment in tests and docstring in NotficationClient
a95f2ca
@heisner-tillman
Remove enable_notication_sytem flag from ini
30c316e
@heisner-tillman
Add typing-extensions to install requirements.
fe2d3e3
@heisner-tillman
Added version guard to test and adjusted .yaml file to enable notific…
404c95b 
…ations
@heisner-tillman
Move duplicated annotation
10b8d16
@nsoranzo @heisner-tillman
Doc fixes
c984902
@heisner-tillman
Refactor put request to return None on 204 response
110ee5c
@heisner-tillman
Remove typing-extensions as it is not longer needed
a1f38e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

@bernt-matthias bernt-matthias bernt-matthias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heisner-tillman @bernt-matthias @bgruening @nsoranzo