Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test report generation/uploading , fixed java version, added workflow triggers #170

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes but overall good stuff thanks - as well as the changes mentioned, please can you:

  1. Change the upload of the build logs to only if failure and add a retention policy of 7 days
  2. Add the upload of the build logs to the PR build too (Reason explained on your Managers PR)

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@jaydee029
Copy link
Contributor Author

A couple of changes but overall good stuff thanks - as well as the changes mentioned, please can you:

  1. Change the upload of the build logs to only if failure and add a retention policy of 7 days
  2. Add the upload of the build logs to the PR build too (Reason explained on your Managers PR)

done

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@jadecarino
Copy link
Contributor

GH workflow fails as Dhruv's namespace doesn't have access to our Maven GPG secrets referenced in the workflow.

@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit 912f7d0 into galasa-dev:main Aug 22, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants