Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop token docs from being filtered out by couchdb when getting tokens #274

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Sep 16, 2024

Why?

Related to changes in #269

When filtering out design documents during operations to get all token documents, some token documents were wrongly being filtered out due to a given endKey=%22_%22 query parameter - this has caused a regression in the CLI's auth tokens get command as it no longer displays all the tokens present in an ecosystem.

This PR fixes the defect by filtering out the design documents after sending the base /_all_docs request.

Also removed an unused logger and fixed unused exception warning during local builds.

@eamansour eamansour merged commit 2f5484f into main Sep 16, 2024
5 checks passed
@eamansour eamansour deleted the fix-auth-tokens-get branch September 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants