Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement loadArtifacts method and stop fetchRun from loading run artifacts by default #273

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Sep 11, 2024

Why?

See galasa-dev/projectmanagement#1210
Related to changes in galasa-dev/framework#649

Changes

  • Implemented the loadArtifacts IRunResult method to separate the loading of artifacts out from fetching runs, which has been causing performance issues in several areas (including getting and deleting runs)
  • Removed duplicate fetch of a run when deleting it by replacing the id parameter in discardRun with the test structure of the run to discard

Note: Builds for this PR will fail until galasa-dev/framework#649 is reviewed and merged

Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks good.

@eamansour eamansour merged commit 3df6dcc into main Sep 13, 2024
5 checks passed
@eamansour eamansour deleted the iss1210-delete-runs-performance branch September 13, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants