refactor: improve output messages #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Remove -check option to avoid this error' is a little ambiguous (e.g., will it just supress the error). Updated to let the user know what will happen if they remove it. Added message for when --check is successful, rather than telling the user the file was created, which should not happen by that command. Changed message for when new generated rules change the CO file, rather than saying a file was created, let them know the generated rules have changed. A CO file being created should be incredibly rare (i.e., maybe the first time this tool is run in a project).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove --check option to avoid this erroris a little ambiguous (e.g., will it just suppress the error). Updated to let the user know what will happen if they remove it.$ npx codeowners-generator generate --check Custom configuration found in /Users/jared.mcateer/Projects/test/package.json ✖ We encountered an error: We found differences between the existing codeowners file and the generated rules. Remove --check option to fix this.Added message for when
--checkis successful, rather than telling the user the file was created, which should not happen with that command.Changed message for when new generated rules change the CO file, rather than saying a file was created, let them know the generated rules have changed. A CO file being created should be incredibly rare (i.e., maybe the first time this tool is run in a project).