fixes for MAST maching mappings. #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MAST thomson scatter machine mapping
torrinba
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
The changes look good to me. I don't have access to test with MAST data, but trust @jmcclena has already confirmed this
Unfortunately they break the regression tests unless pyuda is in the environment. Is that publicly available on any of our systems?
|
@torrinba The only two systems I know that it's installed on are portal and freia. Would it make sense to wrap the import of mast machine mappings in a try-except to quickly get the regression to pass? |
torrinba
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for MAST maching mappings
Add MAST thomson scatter machine mapping