Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use IMAS 3.40.0 #285

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update to use IMAS 3.40.0 #285

merged 1 commit into from
Jan 12, 2024

Conversation

torrinba
Copy link
Collaborator

@torrinba torrinba commented Dec 27, 2023

The primary changes (that I am aware of) in this version of IMAS are:

  1. Renamed gyrokinetic ids to gyrokinetic_local
  2. Restructured pulse_schedule ids to eliminate pulse_schedule...data and pulse_schedule...time entries
  3. Extended the equilibrium ids to include more coordinate options for relevant ids (R, Z, psi, phi, rho_tor_norm) and added an overall chi_squared_reduced metric

Some EFIT machine mapping fixes are also included in this PR along with a name change in some mhdin.dat file variables.

test_omas_dynamic_machine was turned off in this PR because of issue #284.

This is accompanied by the OMFIT PR https://github.com/gafusion/OMFIT-source/pull/6889 and should not be merged until all tests are passing there

The primary changes (that I am aware of) in this version of IMAS are:
1) Renamed gyrokinetic ids to gyrokinetic_local
2) Restructured pulse_schedule ids to eliminate
pulse_schedule.*.*.data and pulse_schedule.*.*.time entries
3) Extended the equilibrium ids to include more coordinate options
for relevant ids (R, Z, psi, phi, rho_tor_norm) and added an overall
chi_squared_reduced metric

Some EFIT machine mapping fixes are also included in this PR along
with a name change in some mhdin.dat file variables.

test_omas_dynamic_machine was turned off in this PR because of an
open issue with omas that results in crashing even on older versions
of the master branch.

This PR will be accompanied by an OMFIT PR as well.
@torrinba
Copy link
Collaborator Author

Any opposition to this merge? If not can someone do the honor?

@smithsp smithsp merged commit 14f4a5f into master Jan 12, 2024
1 check passed
@smithsp smithsp deleted the update_imas branch January 12, 2024 08:25
@hassec
Copy link
Contributor

hassec commented Jan 17, 2024

@smithsp any chance we could update the website to reflect this imas update?

@torrinba
Copy link
Collaborator Author

I think it should be updated automatically as part of the merge pipeline, but sometimes this breaks. The OMFIT website wasn't updating recently either, but it seems to be now, so maybe something similar is happening with the OMAS site?

@hassec
Copy link
Contributor

hassec commented Jan 18, 2024

@bechtt I'm not sure it really works automatically for omas, see discussion in #279

@torrinba
Copy link
Collaborator Author

That's a great point. Do you have any updates on whether OMAS pages are/can be built in the pipeline @kalling?

@hassec
Copy link
Contributor

hassec commented Feb 7, 2024

just for reference, this is fixed since yesterday thanks to @orso82 🎉

@orso82
Copy link
Member

orso82 commented Feb 7, 2024

@torrinba sorry I missed your message. As a repo admin you should now be able to build and update the documentation yourself. Just do make docs at the top level OMAS folder (make html to build it locally without making it live).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants