Mapping to/from rho tor norm #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This my crude attempt to allow mapping between rho_pol_norm <-> rho_tor_norm - This also includes phi - I qualitatively tested rho_pol_norm -> rho_tor_norm - Might have some COCOS issues - Probably overly complicated - Needs dynamic fetching of `phi` and `rho_pol_norm`
- Tested against mapping form OMFITprofiles - Results are OK by eye. Numerical verification still pending.
- Results seem good now
…new_EFIT_mappings_for_IDA
…est_new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…new_EFIT_mappings_for_IDA
…o test_new_EFIT_mappings_for_IDA
…plot_w_new_EFIT_mapping
- Plus 2 missed density_thermal
|
Stale pull request message |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaf of #258
Adds
rho_tor_normto the magnetic coordinatesomas_physics.remap_flux_coordinatescan map between. Wouldn't hurt if this someone double checked my math once #258 is merged. I did do a spot check and while the result wasn't perfect it was not too far off.Arguably a unit test wouldn't hurt here, but I don't have time to write it at the moment.