Finish setting up the mhdin.dat file for CMOD to work with the machine independent style #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e independent style
jmcclena
approved these changes
Sep 20, 2023
|
Hi @jmcclena, are there any examples of using this support file to query cmod? Thanks! |
|
@lajz Right now we only have the mhdin.dat file for cmod. This specifies more static hardware information such as coil locations. To query for cmod data, a machine mapping would need to be created and filled out. |
|
Cool @jmcclena , thanks for the quick reply! Do you know if anyone has previously made an attempt to create the mappings? |
|
@lajz not to my knowledge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file came from an old fork of EFIT/EFUND and had only been partially updated to work with the newer format. Jason Parisi brought this to our attention and made most of the changes to get it working.