Fix DIII-D machine mapping for F-coil currents #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMAS specifies the current should be the measured value for a single turn, but MDS+ stores A-turns. This only impacts F-coils and is related to a quirk for how the coils are specified in EFIT. Also fixed a bad IDS entry and reordered coils in pf_active to match the OMFIT ordering. This MR should be accompanied by corresponding fixes in OMFIT so that k-files are still formed properly (from the OMAS machine mappings).
jmcclena
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAS specifies that coil currents should be the measured value for a single turn, but MDS+ stores A-turns. This only impacts F-coils and is related to a quirk with how the coils are specified in EFIT.
Also fixed a bad IDS entry and reordered coils in pf_active to match the OMFIT ordering.
This PR should be merged ahead of the corresponding fixes in OMFIT https://github.com/gafusion/OMFIT-source/pull/6764 and the OMAS version used in OMFIT should then not be updated until after that PR. This will ensure that k-files are still formed properly from the OMAS machine mappings.