The E coils and F coils do not use same unit #267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E and F coils are combined when loading from the EFIT tree. However, the F coils have the turns multiplied with the current, which one could argue is an preexisting error in MDS+. This would be at least consistently wrong but the F-coils are combined with the E-coils in
pf_current
inconstraints
which are stored correctly.Following options:
pf_current
s. Here it is important to remember that this is the mapping for EFIT not the mapping forpf_active
.I leave it to @smithsp to make an executive decision and @bechtt to add his own opinion.