-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Material and Ayu themes #49
base: main
Are you sure you want to change the base?
Conversation
Delete ayu-dark.R Delete ayu-dark.scss Delete ayu-light.R Delete dracula.R Delete material-lighter.R Delete material-darker.scss Delete ayu-mirage.scss Delete material.scss Delete material-palenight.R Delete material-lighter.scss Delete material-darker.R Delete ayu-mirage.R Delete dracula.scss Delete material-ocean.R Delete material-ocean.scss Delete ayu-light.scss Delete material-palenight.scss Delete material.R Add themes
628d339
to
bfb0511
Compare
@lusignan how did you source the Material theme palette? While testing, I noticed some differences in the colors I see in VS Code and the ones used in the new rsthemes. I found two places where the material colors are described
but I'm not sure if you used those or found a better resource. |
@gadenbuie I generated a json of the theme from VS Code's command palette (identical to the first link you posted) and then used the hex codes from that to build the rsthemes version. The hex code for gold looked more orange in RStudio than it did in VS Code, however, so I modified that for the rstheme. The backgrounds also looked different in RStudio so I used Chrome's "ColorPick Eyedropper" extension to find a closer match. The hex codes in the second link are for the accent options in VS Code's UI but are not colors used in the syntax theme. |
Moved the PR #47 by @lusignan into a new PR branch to pick up new changes in rsthemes. Also remaining tasks are mostly documenting and reviewing.