Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Avoid locator searches in current layer if it has been marked as not searchable #45

Closed
wants to merge 1 commit into from

Conversation

gacarrillor
Copy link
Owner

@gacarrillor gacarrillor commented Oct 16, 2024

No description provided.

Copy link

github-actions bot commented Oct 16, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 90485c7)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 3ea3573)

@3nids
Copy link

3nids commented Oct 16, 2024

I'm not 100% sure here.
If we are on a specific layer and want to search in this one?
But this might be more coherent you are right.

@gacarrillor
Copy link
Owner Author

I'm not 100% sure here. If we are on a specific layer and want to search in this one? But this might be more coherent you are right.

@3nids, yeah, if layer features of a specific layer are to be searchable via QGIS locator, the layer's Searchable setting shouldn't be disabled.

This is to add consistency with e.g., Identifiable behavior, which when disabled, makes a layer impossible to identify even by setting the identify mode to Current Layer in the Identify Results panel.

image

Would it be OK for you if I point this PR to QGIS master?

@3nids
Copy link

3nids commented Oct 19, 2024

Yes go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants