[feature] Allow users to save expression functions in QGIS project file #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
force-pushed
the
save_functions_in_project
branch
from
dd37bc5
to
57dbdaf
Compare
gacarrillor
force-pushed
the
save_functions_in_project
branch
from
6c8a9a7
to
dc84fc1
Compare
nirvn
reviewed
Jun 25, 2024
gacarrillor
force-pushed
the
save_functions_in_project
branch
from
dc84fc1
to
7bc69a2
Compare
Thanks a lot for your review, all changes were applied in e9f736e |
gacarrillor
force-pushed
the
save_functions_in_project
branch
4 times, most recently
from
889fbfc
to
0b73ff2
Compare
gacarrillor
force-pushed
the
save_functions_in_project
branch
from
0b73ff2
to
7b24c9d
Compare
gacarrillor
force-pushed
the
save_functions_in_project
branch
2 times, most recently
from
14ce964
to
154adac
Compare
…ways at the top of the list in the 'Function editor' tab) and never stored in a user profile file
…e whether to store functions in a .py file (current behavior) or in the QGIS project
…e param, tr, string literals)
… users allow it, just like we do with macros
…se and reload user expressions (from profile) to avoid any potential overwrite from unloaded project functions
… project close) and reloading user ones, specifically to restore overwritten user functions when opening a project with expressions inside
…nsFromProject to QgsProject::read and ::clear, respectively. Introduce function pythonEmbeddedInProjectAllowed to ask for permissions to load both macros and expression functions, with a parameter enum and rename existing enum for macros. Sort includes. Drop not needed file. Add python/expressions/ to gitignore, to get rid of files produced by the introduced Python test.
gacarrillor
force-pushed
the
save_functions_in_project
branch
from
154adac
to
c5286e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the expression builder dialog, Python functions can only be saved in the user profile directory. If a user wants to share expression functions with colleagues, he/she needs to share his/her expressions directory or individual
.pyfiles, which is inconvenient (without mentioning the installation of those shared files won't be trivial either).This PR allows users to also store expression functions into the current QGIS project file, making it easier to share functions with other interested parties.
Some details about the implementation:
[Project Functions]item will be listed in the left-hand side list widget (Function Editortab).[Project Functions]item already exists in the list, the corresponding option in theAdd Function Filedialog will be disabled.Labels: [Needs Documentation] [Feature] [Expressions]
Funded by the QGIS user group Switzerland.