[core] Introduce QgsProfileSourceRegistry #41
Conversation
|
|
||
| QList< QgsAbstractProfileSource * > QgsProfileSourceRegistry::profileSources() const | ||
| { | ||
| return mSources; |
There was a problem hiding this comment.
I am not sure if the registry should return all the sources.
Shouldn't it return a clone of a source if you ask for a given id?
That's the way other registries are working
There was a problem hiding this comment.
I took QgsExternalStorageRegistry as a basis, but I guess I should've had a look at other registries as well.
The rationale behind this is that we need to get the full list in order to iterate the sources in QgsElevationProfileCanvas, see https://github.com/gacarrillor/QGIS/pull/41/files#diff-7858eaf011cbfda84a6f705b8e0c0f64b95b113bf9a602d2fe6aa51548495862R848
gacarrillor
force-pushed
the
profile_source_registry
branch
from
bee8a9e
to
b272322
Compare
Tests failed for Qt 5One or more tests failed using the build from commit 625fdee custom_profilecustom_profileTest failed at test_layout_item_profile_custom_source at tests/src/python/test_qgsprofilesourceregistry.py:403 Rendered image did not match tests/testdata/control_images/expected_custom_profile/expected_custom_profile.png (found 130 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
gacarrillor
force-pushed
the
profile_source_registry
branch
from
625fdee
to
d6ff1f5
Compare
… map layers, e.g., based on web services
…ce is not a map layer (e.g., from web services)
gacarrillor
force-pushed
the
profile_source_registry
branch
from
79f6805
to
1986f12
Compare
To store profile sources other than map layers, e.g., based on web services