[dxf] Allow users to override the layer name to be exported to DXF #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
force-pushed
the
dxf_overridden_name
branch
from
ef1675f
to
ed1cbcd
Compare
gacarrillor
force-pushed
the
dxf_overridden_name
branch
from
7313649
to
13b0f62
Compare
gacarrillor
force-pushed
the
dxf_overridden_name
branch
from
76cad50
to
3b778d6
Compare
…fLayerJob->layerTitle replaced by layerDerivedName, to avoid confusion with one of the final DXF layer name sources (layer metadata title, layer server properties title, layer name, layer's overridden name)
…attribute, 2: layer title, 3: overridden name, 4: layer name)
…nce precedence is until now not clear for them
gacarrillor
force-pushed
the
dxf_overridden_name
branch
from
3b778d6
to
a76439d
Compare
…t resolution with PR 57103)
…(by using the QgsFilterLineEdit with default value)
…the former can be changed in the export dialog, whereas the latter must be done in the layer properties, therefore, overridden layer name is closer to the export intention and should take the precedence)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to override the output name of individual layers exported in the DXF Export dialog.
The corresponding processing algorithm's GUI and parameter were also updated accordingly.
Tests were added for:
qgsprocessingparameterdxflayersparameter and DXF layer's widget wrapper.Screencast App dialog
2024-03-19.18-11-48.mp4
Screencast Processing dialog
2024-03-25.10-54-11.mp4
UX hints for the users: