Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Avoid non-spatial vector layers in DXF Export alg #34

Closed
wants to merge 3 commits into from

Conversation

gacarrillor
Copy link
Owner

DXF export functionality doesn't accept non-spatial layers. However, this is the scenario nowadays:

  • DXF Export app dialog does not even show non-spatial layers, which is good!
  • DXF processing algorithm:
    • Shows non-spatial layers and allows users to configure them as valid inputs.
    • Fails at exporting non-spatial layers throwing a "DXF export failed, the extent could not be determined" error message.

To improve the DXF export algorithm behavior, this PR makes non-spatial layers non-acceptable input values for the DXF Export alg. As a result, users won't even have those layers listed in the algorithm dialog, which is cleaner, and in the case of big projects, highly desirable.

Some tests were added as well.

Copy link

github-actions bot commented Mar 12, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit f9390ff)

Copy link

Tests failed for Qt 5

One or more tests failed using the build from commit f9390ff

WMS_GetMap_Highlight_Empty_Labels

WMS_GetMap_Highlight_Empty_Labels

Test failed at test_wms_getmap_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getmap.py:1391

Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetMap_Highlight_Empty_Labels/WMS_GetMap_Highlight_Empty_Labels.png (found 271 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@gacarrillor gacarrillor deleted the dxfexport_alg_nonspatial_layers branch March 15, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants