Add Phenopacket schema implementation links #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaudis
approved these changes
Nov 24, 2022
buske
approved these changes
Dec 7, 2022
|
Thanks for this, @julesjacobsen! Is there anything special a developer needs to do to use the GA4GH Pedigree or Relationship messages? |
|
@buske once this has been merged into the main branch and released, no. It'll all be available to use from the proto schema/jar. It's useable now, but someone will need to explicitly build from that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm awaiting a review on the changes (phenopackets/phenopacket-schema#364) before these links are available on the main branch of the phenopacket-schema repo and in the docs. Hopefully they should be merged after Thanksgiving.
I've updated the examples using the pheopacket-schema to use lowerCamelCase as this is what we recommend for maximum portability (I know the proto field names are snake_case).