Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import all other unit definitions from CLHEP #176

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Sep 9, 2024

fixes #175

(the code layout is different, as this actually just the original setSystemOfUnits.cc from CLHEP converted to python by some c preprocessor magic and sed)

@ManuelHu
Copy link
Contributor Author

ManuelHu commented Sep 9, 2024

We would have to discuss what of those changes to keep, before I would start working on the failed tests :-)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (fab6b07) to head (6cd6037).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   70.00%   70.31%   +0.31%     
==========================================
  Files         152      152              
  Lines       23170    23413     +243     
==========================================
+ Hits        16220    16463     +243     
  Misses       6950     6950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManuelHu
Copy link
Contributor Author

@stewartboogert If CI passes, this PR would be ready from my side

@stewartboogert stewartboogert merged commit 21837f2 into g4edge:main Sep 23, 2024
17 checks passed
@ManuelHu ManuelHu deleted the patch-2 branch September 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit handling is insufficient
2 participants