Update NewFileURI to support relative paths #5243
Open
+50
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rip up when the URI is used on a different system
|
Thanks for fixing the bug, LGTM. The added documentation is exactly what I was asking for as well. |
Jacalz
requested changes
Nov 10, 2024
| if parent[len(parent)-1] != filepath.Separator { | ||
| child := filepath.Base(s) | ||
| parent := s[:len(s)-len(child)] | ||
| if parent[len(parent)-1] != '/' { |
There was a problem hiding this comment.
Already a problem before this change obviously but will this not do parent[-1] if parent is empty? Maybe that can't ever happen but I just got a bit worried when seeing it now :)
| parent = filepath.Dir(s) | ||
| if parent[len(parent)-1] != filepath.Separator { | ||
| child := filepath.Base(s) | ||
| parent := s[:len(s)-len(child)] |
There was a problem hiding this comment.
Was there something wrong with filepath.Dir? If so, this might warrant a comment as to why we are hard coding the logic.
| func NewFileURI(path string) fyne.URI { | ||
| assumeAbs := false |
There was a problem hiding this comment.
How about using filepath.IsAbs()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up docs to clarify as well.
Fixes #5234
Checklist: