Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Count call without filters #94

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

ashwin1111
Copy link
Contributor

@ashwin1111 ashwin1111 commented Oct 4, 2024

Fixes #93
https://app.clickup.com/t/86cwppd8q

Summary by CodeRabbit

  • New Features

    • Enhanced filtering options for counting and retrieving data through the API, allowing users to specify custom parameters.
  • Bug Fixes

    • Improved error handling and data processing for API calls without specific filters.
  • Chores

    • Updated version number of the SDK from 1.23.0 to 1.23.1.

Copy link

coderabbitai bot commented Oct 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the ApiBase class in the sageintacctsdk/apis/api_base.py file, enhancing several methods to accept optional parameters for filtering. Specifically, the count, get_all, get_all_generator, and get_by_query methods have updated signatures and conditional logic to allow for dynamic filtering based on user inputs. Additionally, the version number in the setup.py file has been incremented from 1.23.0 to 1.23.1.

Changes

File Change Summary
sageintacctsdk/apis/api_base.py Updated method signatures for count, get_all, get_all_generator, and get_by_query to accept optional filtering parameters. Enhanced conditional logic for filtering in these methods.
setup.py Version number updated from 1.23.0 to 1.23.1.

Possibly related PRs

  • Bump version #90: The changes in this PR involve a version bump in setup.py, which is related to the main PR's version update but does not directly connect to the modifications made in the ApiBase class or its methods.

Suggested reviewers

  • NileshPant1999
  • anishfyle

Poem

In the code where rabbits play,
Filters hop and dance today.
With each method, new paths bloom,
Count and get, dispelling gloom.
Version's up, a leap so spry,
Hopping high, we touch the sky! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Oct 4, 2024

PR description must contain a link to a ClickUp (case-insensitive)

@ashwin1111 ashwin1111 merged commit c254d56 into master Oct 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GL Detail and Journal Entries API Access
2 participants