Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: personal-cards-typeerror o.complete #3192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: personal-cards-typeerror o.complete #3192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/fyle/personal-cards/personal-cards.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
import { Expense } from 'src/app/core/models/expense.model';
import { ToastMessageComponent } from 'src/app/shared/components/toast-message/toast-message.component';

type Filters = Partial<{

Check failure on line 58 in src/app/fyle/personal-cards/personal-cards.page.ts

View workflow job for this annotation

GitHub Actions / Run linters 

Types should be defined only in files with .model.ts extension
amount: number;
createdOn: Partial<{
name?: string;
Expand Down Expand Up @@ -434,7 +434,7 @@
this.loadData$.next(params);

setTimeout(() => {
event?.target?.complete();
event?.target?.complete?.();
}, 1000);
}

Expand Down Expand Up @@ -471,7 +471,7 @@
if (this.selectionMode) {
this.switchSelectionMode();
}
this.selectedTrasactionType = event.detail.value as string;

Check failure on line 474 in src/app/fyle/personal-cards/personal-cards.page.ts

View workflow job for this annotation

GitHub Actions / Run linters 

This assertion is unnecessary since it does not change the type of the expression
this.acc = [];
const params = this.loadData$.getValue();
const queryParams = params.queryParams || {};
Expand Down
Loading