Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only logging.NullHandler to default_logger #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add only logging.NullHandler to default_logger #704

wants to merge 1 commit into from

Conversation

bsolomon1124
Copy link

This is a library, not an application, and it should be up to the end user, not the developer, what the log level and handler is.

Setting up the logger with a DEBUG level and sys.stderr handler is not a widely used practice in Python libraries. The common practice is to add only NullHandler:

An instance of this handler could be added to the top-level logger of the logging namespace used by the library (if you want to prevent your library’s logged events being output to sys.stderr in the absence of logging configuration).

See also:
https://docs.python-guide.org/writing/logging/#logging-in-a-library

This is a library, not an application, and it should be up to the
end user, not the developer, what the log level and handler is.

Setting up the logger with a DEBUG level and sys.stderr handler
is not a widely used practice in Python libraries.  The common
practice is to add only NullHandler:

> An instance of this handler could be added to the top-level
> logger of the logging namespace used by the library
> (if you want to prevent your library’s logged events
> being output to sys.stderr in the absence of logging configuration).

See also:
https://docs.python-guide.org/writing/logging/#logging-in-a-library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant