Make tests work with Karma and Chrome (Closes #60) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +97,6 @@ | |||
| "sinon-chai": "^2.8.0", | |||
| "stylelint": "^6.5.1", | |||
| "stylelint-config-standard": "^8.0.0", | |||
| "uglify-js": "github:mishoo/UglifyJS2#harmony" | |||
| "uglify-js": "github:mishoo/UglifyJS2#766fafda8baefe6d150df27dfad7e99857c08557" | |||
There was a problem hiding this comment.
waiting for mishoo/UglifyJS#1229
There was a problem hiding this comment.
nit: Can we make a GitHub issue and mention the related issue?
julienw
force-pushed
the
add-tests-2
branch
3 times, most recently
from
f72d815 to
1d68305
Compare
| 'tests/unit/test-main.js', | ||
| ], | ||
|
|
||
| // Test results reporter to use. | ||
| reporters: ['mocha'], | ||
|
|
||
| mochaReporter: { | ||
| showDiff: true, | ||
| }, |
There was a problem hiding this comment.
we can have nice things
|
r? @samgiles :) |
julienw
changed the title
|
Looks good to me! And it passed on Travis! Woohoo, nice work! I'll merge. [Sorry for the delay :| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.