Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule and sponsor #216

Merged
merged 10 commits into from
Nov 4, 2023
Merged

Schedule and sponsor #216

merged 10 commits into from
Nov 4, 2023

Conversation

Shiven110504
Copy link
Member

Will fix the Merge Request in sometime.
Fixed the FAQ lines, sponsor email and removed sponsor block at the EOP to make page more concise

@Shiven110504
Copy link
Member Author

Resolved issue #178 #209

@ntdkhiem
Copy link
Member

This is very cluttering.
image
Could you add margin so that it would look like more consistent to the rest of the sections?
image

@ntdkhiem
Copy link
Member

Could we add back FAQ (or something else like Have a Question?) at the top of this section so it will be consistent with the rest?
image

Copy link
Member

@ntdkhiem ntdkhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the suggestions above.

@Shiven110504 Shiven110504 requested a review from ntdkhiem October 29, 2023 20:50
ammuiyer
ammuiyer previously approved these changes Oct 31, 2023
Copy link
Contributor

@ammuiyer ammuiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shiven110504 Shiven110504 requested a review from ntdkhiem November 4, 2023 20:40
Copy link
Member

@ntdkhiem ntdkhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntdkhiem ntdkhiem merged commit 7db4f47 into main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants