New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File scoped and explicit enums #19

Open

jeffward01 wants to merge 5 commits into furkandeveloper:master from jeffward01:file-scoped_and_explicit-enums

jeffward01 commented Oct 1, 2022

Summary

*** Summary is here ***

Changes made:

Changed all files to 'file-scoped' namespaces
Resharper automatically formatted the namespaces and using statements
Added methods for Enum version of boolean as no tracking
Added Obsolete messages
Changed a typo of async Task<int> Count(....) to async Task<int> CountAsync(....)
Changed the Enum version of the method:
Changed only the enum version of the method GetById to use the AsNoTracking option. See below

    public TEntity GetById<TEntity>(bool asNoTracking, object id)
        where TEntity : class
    {
        return this._context.Set<TEntity>()
            .FirstOrDefault(this.GenerateExpression<TEntity>(id));
    }

    /// <inheritdoc />
    public TEntity GetById<TEntity>(EfTrackingOptions asNoTracking, object id)
        where TEntity : class
    {
        var queryable = this.FindQueryable<TEntity>(asNoTracking)
            .FirstOrDefault(this.GenerateExpression<TEntity>(id));

        return queryable;
    }

If you want, I can also apply the change to the classic boolean GetById<TEntity>(bool, object) method. I did not want to introduce any breaking changes, so I skipped this on the classic version.

jeffward01 added 5 commits

September 26, 2022 18:47


          changed to file-scoped via resharper

b1dc6cb


          added EfTrackable to IRepository

cfcae5d


          added enum for asNoTracking

e0ed0d2


          added obsolete message and attribute to all boolean 'asNoTracking' me…

fb8ce72

…thods


          iterated package version to 2.0.1

72e6455

furkandeveloper self-requested a review

October 1, 2022 10:22

furkandeveloper self-assigned this

furkandeveloper added the enhancement label

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

Comment on lines +38 to +39

		var book = await this._unitOfWork.Repository.AddAsync<Book, Guid>(
		new Book

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

+                              AuthorId = entity.Id
+                          });
+                      await this._unitOfWork.Repository.CompleteAsync();

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

+                  [HttpPost("range")]
+                  public async Task<IActionResult> AddAuthorAsync([FromBody] List<AuthorRequestDto> dto)
+                  {
+                      var entity = await this._unitOfWork.Repository.AddRangeAsync<Author, Guid>(

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

+                  [HttpGet("filterable-multiple")]
+                  public async Task<IActionResult> GetFilterableMultipleAsync([FromQuery] AuthorFilterDto dto)
+                  {
+                      var entities = await this._unitOfWork.Repository.GetMultipleAsync<Author, AuthorFilterDto, object>(

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

+                  public async Task<IActionResult> GetIncludeableFilterableMultipleAsync([FromQuery] AuthorFilterDto dto)
+                  {
+                      Func<IQueryable<Author>, IIncludableQueryable<Author, object>> include = a => a.Include(i => i.Books);
+                      var entities = await this._unitOfWork.Repository.GetMultipleAsync<Author, AuthorFilterDto, object>(

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

Comment on lines +120 to +122

		var entities = await this._unitOfWork.Repository.GetMultipleAsync<Author>(false);

		return this.Ok(entities);

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

Comment on lines +128 to +130

+                      var entities = await this._unitOfWork.Repository.GetMultipleAsync<Author, object>(
+                          false,
+                          select => new

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

Comment on lines +142 to +145

+                      var entity = await this._unitOfWork.Repository.GetByIdAsync<Author>(true, id);
+                      await this._unitOfWork.Repository.HardDeleteAsync(entity);
+                      return this.NoContent();

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper reviewed

View reviewed changes

sample/EasyRepository.Sample/Controllers/AuthorController.cs

Comment on lines +151 to +154

+                      var entity = await this._unitOfWork.Repository.GetByIdAsync<Author>(true, id);
+                      await this._unitOfWork.Repository.SoftDeleteAsync<Author, Guid>(entity);
+                      return this.NoContent();

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

furkandeveloper requested changes

View reviewed changes

Owner

furkandeveloper left a comment

Too many unnecessary 'this' qualifiers are used.
All of these need to be removed.

furkandeveloper reviewed

View reviewed changes

src/EasyRepository.EFCore.Generic/Repository.cs

    
                      }

                  public async Task CompleteAsync(CancellationToken cancellationToken = default)

                  {

                      await this._context.SaveChangesAsync(cancellationToken)

Owner

furkandeveloper Oct 1, 2022

Remove unnecessary 'this' qualifier @jeffward01

This was linked to issues Oct 1, 2022

✨ [FEATURE] Add 'Enum.AsNoTracking' to all methods instead of using bool values #16

Open

✨ [FEATURE] Would like to migrate to 'file scoped' namespaces #17

Open

Owner

furkandeveloper commented Oct 1, 2022

Let the methods using normal bools stay for now. I don't think it's necessary to make a big change in one go.
We will remove it in future versions. @jeffward01

Author

jeffward01 commented Oct 1, 2022

First of all, big thank you for all of your change requests! I would much rather that you mention your opinion and suggest changes, rather than 'just hit accept'. Thank you.

Let the methods using normal bools stay for now. I don't think it's necessary to make a big change in one go.
We will remove it in future versions. @jeffward01

Are the [Obsolete] attributes I added alright?

Remove unnecessary 'this' qualifier

Ahh, your one of these people who dislike this. ❤️ || I understand why people dislike them, I also understand why people like them. No issue at all!

I will remove all of this. keywords AND make an .editorconfig file that is .sln scoped for the library so that the coding standards could be maintained. Please give me a few days to do this

jeffward01 mentioned this pull request

✨ [FEATURE] Enable Nullable Reference Types, add null exceptions, add null checks #22

Open

Owner

furkandeveloper commented Oct 1, 2022

First of all, big thank you for all of your change requests! I would much rather that you mention your opinion and suggest changes, rather than 'just hit accept'. Thank you.

Let the methods using normal bools stay for now. I don't think it's necessary to make a big change in one go.
We will remove it in future versions. @jeffward01

Are the [Obsolete] attributes I added alright?

Remove unnecessary 'this' qualifier

Ahh, your one of these people who dislike this. ❤️ || I understand why people dislike them, I also understand why people like them. No issue at all!

I will remove all of this. keywords AND make an .editorconfig file that is .sln scoped for the library so that the coding standards could be maintained. Please give me a few days to do this

You are right, with .editorconfig these problems can be avoided. We are waiting for you. :D

jeffward01 mentioned this pull request

Add support for EFCore AsNoTracking() Linq extension. fluxera/Fluxera.Repository#57

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels