Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/change loglevel #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FeepingCreature
Copy link
Collaborator

Add loglevel.c, a system-level tool to directly modify the log level of a running D process using util.log.

@FeepingCreature FeepingCreature force-pushed the feature/change-loglevel branch from 46cc40c to 1fc5c22 Compare August 2, 2024 14:21
Copy link
Member

@linkrope linkrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I told the AI to rewrite this program in idiomatic D, the AI praised itself for how much better the code was then. Maybe you can even reuse data types this way?

@FeepingCreature
Copy link
Collaborator Author

FeepingCreature commented Aug 12, 2024

Lol. The simple answer is I have this installed setuid root internally, and I just barely trust the C functions I call to run setuid root... I do not trust the D runtime. I'm not even sure I trust it to run sudo tbh.

When I'm messing with internals like this, I want the absolute minimum of abstraction.

@linkrope
Copy link
Member

Yeah: trust is an issue... Also: what's the related means, for example, for TypeScript services?
Should we consider the possible requirement that the level change survives a service restart?

@FeepingCreature
Copy link
Collaborator Author

I mean... then you start looking at things like config db and notifications and have to pull a lot of complexity in. That's why we didn't have any feature that could do this, despite it being useful, for years.

@FeepingCreature FeepingCreature force-pushed the feature/change-loglevel branch from f91e156 to 6dac11e Compare August 22, 2024 12:39
@FeepingCreature FeepingCreature force-pushed the feature/change-loglevel branch from 6dac11e to e824669 Compare August 22, 2024 12:40
@FeepingCreature
Copy link
Collaborator Author

Replaced PR with a simple link to the branch I pushed to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants