Support string interpolation #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeepingCreature
force-pushed
the
fix/support-string-interpolation
branch
from
6c4995a to
6f098b2
Compare
linkrope
reviewed
Jun 12, 2024
linkrope
reviewed
Jun 12, 2024
linkrope
reviewed
Jun 12, 2024
linkrope
reviewed
Jun 12, 2024
| @@ -185,11 +212,11 @@ struct Log | |||
|
|
|||
| // Helper to allow using named references in format strings, ie. treat %{name} equivalent to %s. | |||
There was a problem hiding this comment.
What's intended for this idea in the future? Will it be deprecated?
Or does it have to be extended like $foo(42)?
There was a problem hiding this comment.
I was intending for it to correspond to named arguments eventually; I think that's still useful. I'd leave it for now. We need more experience with how interpolated strings and named args look in practice.
linkrope
reviewed
Jun 12, 2024
linkrope
requested changes
Jun 12, 2024
FeepingCreature
force-pushed
the
fix/support-string-interpolation
branch
from
6f098b2 to
d38ab58
Compare
FeepingCreature
force-pushed
the
fix/support-string-interpolation
branch
from
d38ab58 to
86326d8
Compare
linkrope
reviewed
Jun 19, 2024
| static if (supportsStringInterpolation) | ||
| { | ||
| // Placeholder pending https://issues.dlang.org/show_bug.cgi?id=24550 | ||
| private void formattedWrite(Sink, Args...)(ref Sink sink, InterpolationHeader _header, Args args, |
There was a problem hiding this comment.
Nicer line break?
private void formattedWrite(Sink, Args...)(ref Sink sink,
InterpolationHeader _header, Args args, InterpolationFooter _footer)
linkrope
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support string interpolation added in DMD 2.108, ie.
log.info(i"The answer is $(42)");.Older compilers remain supported.