Disallow (maybe/just nil) #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove nullary clause, since that doesn't make much sense anyway, and add a precondition to the remaining unary clause to ensure v is non-nil. Update the docsctring accordingly.
In -mreturn, if v is nil, return #<Nothing>, otherwise #<Just v>.
(return b) instead of (return nil) This is mostly so the maybe tests pass and could be very misguided.
|
I think we better |
(return true) per @dialelo's suggestion. #149 (comment)
|
Sounds good to me and the tests passed locally. I'm actually going to bed now... 💤 |
|
Sweet dreams 😴 |
ghost
merged commit
hojacartaft
added a commit
to hojacartaft/cats
that referenced
this pull request
Aug 25, 2024
(return true) per @dialelo's suggestion. funcool/cats#149 (comment)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
#'cats.core.monad.maybe/justRemove nullary clause and add a precondition to the remaining unary clause to ensure
vis non-nil.Update the docsctring accordingly.
Update
'cats.monad.maybeIn
-mreturn, ifvisnil, return#<Nothing>, otherwise#<Just v>.Update
#'cats.core/guard(return true)instead of(return nil)Fixes #148.