ci: add string parse to boolean schema

fullstacksjs · Oct 28, 2023 · c087aa7 · c087aa7
1 parent 80cbd43
commit c087aa7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Schema/BooleanSchema.spec.ts b/src/Schema/BooleanSchema.spec.ts
@@ -37,4 +37,12 @@ describe('Boolean Schema', () => {
     expect(schema.parse()).toBe(true);
     expect(schema2.parse()).toBe(false);
   });
+
+  it('should parse string to boolean', () => {
+    const schema = new BooleanSchema().setValue('true');
+    const schema2 = new BooleanSchema().setValue('false');
+
+    expect(schema.parse()).toBe(true);
+    expect(schema2.parse()).toBe(false);
+  });
 });
diff --git a/src/Schema/BooleanSchema.ts b/src/Schema/BooleanSchema.ts
@@ -2,11 +2,12 @@ import { Schema } from './Schema';
 import type { SchemaOptions } from './SchemaOptions';
 
 export class BooleanSchema<TInput = any> extends Schema<TInput, boolean> {
+  private falseRegex = /false/i;
   constructor(options: SchemaOptions<boolean> = {}) {
     super({
       ...options,
       typeConstructor: n => {
-        console.log(`${n} to boolean`);
+        if (typeof n === 'string' && this.falseRegex.test(n)) return false;
 
         return Boolean(n);
       },