Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for scripts to build on Heroku #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add instructions for scripts to build on Heroku #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,30 @@ git push heroku master
```

Heroku will give you a link at which to view your live app.

#### Build directly on Heroku

Other option is to build client project on Heroku by adding scripts on post-build hook.

Add to root `package.json`:

"scripts": {
"heroku-postbuild": "npm --prefix client run installDep && npm --prefix client run build",
// ...

Also add to subproject's `client/package.json`:


"scripts": {
// ...
"installDep": "npm install"

Now prepare Heroku and deploy:

heroku apps:create food-lookup-demo
git push heroku master
heroku open

This will trigger installation of dependencies and building client application.

Now, server will serve React application as static content on `/` route.