include default meta in addMeta overwrite method
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
overwrite.addMetadoes not make it easy to get the runtime's default meta if you're just looking to extend it with additional pieces of meta information (such as a request ID).This PR allows the default meta to be passed into the overwrite method so that you can return it again, preserving existing behaviour whilst giving you an entry point to extend the meta, rather than replace it.
This has been done in a non-breaking way, existing implementations will work without any changes, whilst the API allows you to provide an optional new argument to populate the default meta. Existing uses of
tslogwill be unaffected by this change.