Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unpin fgpyo dependency #97

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: unpin fgpyo dependency #97

merged 1 commit into from
Dec 5, 2024

Conversation

msto
Copy link
Collaborator

@msto msto commented Dec 5, 2024

Does fgpyo need to be pinned to 0.7.1, or can we use our usual caret dependency to permit any 0.x minor version at 0.8 or later?

I'd at least like to bump the version to 0.8.0 - it'd be helpful in a client project to have fgpyo.io.assert_fasta_indexed() available, which was added in 0.8.0.

@msto msto requested review from nh13 and tfenne as code owners December 5, 2024 16:53
Copy link

coderabbitai bot commented Dec 5, 2024

Warning

Rate limit exceeded

@msto has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3ea6178 and bbdad5c.

Walkthrough

The pull request includes modifications to the pyproject.toml file, specifically in the dependencies section. The version of the fgpyo dependency has been updated from "0.7.1" to "^0.8.0", allowing for more flexible versioning within the 0.x range. No new dependencies were added or removed, and the overall structure of the file remains unchanged.

There are no alterations to the declarations of exported or public entities aside from this version update. The sections related to tool.poetry, tool.poetry.dependencies, and tool.poetry.group.dev.dependencies have not been modified in terms of their content or structure. The changes focus solely on the dependency version, with no new functionality introduced or existing logic altered.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

msto added a commit that referenced this pull request Dec 5, 2024
Similar to #97 , this PR unpins the dependency on pybedlite.

I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
Does `fgpyo` need to be pinned to `0.7.1`, or can we use our usual [caret dependency](https://python-poetry.org/docs/dependency-specification/#caret-requirements) to permit any `0.x` minor version at 0.8 or later?

I'd at least like to bump the version to 0.8.0 - it'd be helpful in a client project to have `fgpyo.io.assert_fasta_indexed()` available, which was added in 0.8.0.

chore: update lockfile
msto added a commit that referenced this pull request Dec 5, 2024
Similar to #97 , this PR unpins the dependency on pybedlite.

I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (f62c4b5) to head (bbdad5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #97    +/-   ##
========================================
  Coverage   96.66%   96.66%            
========================================
  Files          26       26            
  Lines        1708     1708            
  Branches      333      189   -144     
========================================
  Hits         1651     1651            
  Misses         31       31            
  Partials       26       26            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msto
Copy link
Collaborator Author

msto commented Dec 5, 2024

I'd also really like to be able to use MetricWriter in this project! 😄

@msto msto merged commit 3c3ed80 into main Dec 5, 2024
7 checks passed
@msto msto deleted the ms_unpin-fgpyo branch December 5, 2024 22:13
tfenne pushed a commit that referenced this pull request Dec 13, 2024
Similar to #97 , this PR unpins the dependency on pybedlite.

I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
tfenne pushed a commit that referenced this pull request Dec 13, 2024
Similar to #97 , this PR unpins the dependency on pybedlite.
---------
Co-authored-by: tfenne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants