-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unpin fgpyo dependency #97
Conversation
Warning Rate limit exceeded@msto has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request includes modifications to the There are no alterations to the declarations of exported or public entities aside from this version update. The sections related to Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Similar to #97 , this PR unpins the dependency on pybedlite. I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
Does `fgpyo` need to be pinned to `0.7.1`, or can we use our usual [caret dependency](https://python-poetry.org/docs/dependency-specification/#caret-requirements) to permit any `0.x` minor version at 0.8 or later? I'd at least like to bump the version to 0.8.0 - it'd be helpful in a client project to have `fgpyo.io.assert_fasta_indexed()` available, which was added in 0.8.0. chore: update lockfile
Similar to #97 , this PR unpins the dependency on pybedlite. I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
========================================
Coverage 96.66% 96.66%
========================================
Files 26 26
Lines 1708 1708
Branches 333 189 -144
========================================
Hits 1651 1651
Misses 31 31
Partials 26 26 ☔ View full report in Codecov by Sentry. |
I'd also really like to be able to use |
Similar to #97 , this PR unpins the dependency on pybedlite. I am opening two separate PRs in case there is an argument for one dependency to be pinned but not the other.
Similar to #97 , this PR unpins the dependency on pybedlite. --------- Co-authored-by: tfenne <[email protected]>
Does
fgpyo
need to be pinned to0.7.1
, or can we use our usual caret dependency to permit any0.x
minor version at 0.8 or later?I'd at least like to bump the version to 0.8.0 - it'd be helpful in a client project to have
fgpyo.io.assert_fasta_indexed()
available, which was added in 0.8.0.