Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate build_and_pick_primer_pairs and pick_top_primer_pairs #39

Closed
wants to merge 1 commit into from

Conversation

msto
Copy link
Collaborator

@msto msto commented Sep 23, 2024

Related to #38

I think we should deprecate, to avoid new use of these functions in client code, while waiting for any dependent client repos to be updated.

@msto msto requested review from nh13 and tfenne as code owners September 23, 2024 16:08
@msto msto changed the title chore: Deprecate build_and_pick_primer_pairs and pick_top_primer_pairs refactor: Deprecate build_and_pick_primer_pairs and pick_top_primer_pairs Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (70f6840) to head (7322a0a).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          25       25           
  Lines        1597     1600    +3     
  Branches      302      302           
=======================================
+ Hits         1555     1558    +3     
  Misses         23       23           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msto msto closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants