refactor: export OffTargetDetector #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msto
force-pushed
the
ms_export-offtarget-detector
branch
from
7446d19 to
47eb730
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 25 25
Lines 1597 1598 +1
Branches 302 302
=======================================
+ Hits 1555 1556 +1
Misses 23 23
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
I tend to agree .. but can you also search/replace to fix the imports in the examples please? |
|
Yep, done. (And did the same for #36 ) |
msto
force-pushed
the
ms_export-offtarget-detector
branch
from
ac7f0af to
2178e40
Compare
msto
commented
Sep 23, 2024
Comment on lines
22
to
27
| from prymer.api.melting import calculate_long_seq_tm | ||
| from prymer.api.minoptmax import MinOptMax | ||
| from prymer.api.picking import FilteringParams | ||
| from prymer.api.picking import _dist_penalty | ||
| from prymer.api.picking import _seq_penalty | ||
| from prymer.api.picking import build_and_pick_primer_pairs | ||
| from prymer.api.picking import build_primer_pairs | ||
| from prymer.api.picking import check_primer_overlap | ||
| from prymer.api.picking import is_acceptable_primer_pair | ||
| from prymer.api.picking import pick_top_primer_pairs | ||
| from prymer.api.picking import score as picking_score |
There was a problem hiding this comment.
Note that the remaining functions are not included in the api namespace, and must be imported from the appropriate submodule.
IMO these functions should either be added to the api namespace, or marked as private with a leading underscore, but I don't think that needs to fall within the scope of this PR
tfenne
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be in the
offtargetnamespace ifOffTargetResultis