fix: allow newer pybwa #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #118 +/- ##
==========================================
- Coverage 95.37% 94.96% -0.42%
==========================================
Files 18 16 -2
Lines 1493 1411 -82
Branches 175 161 -14
==========================================
- Hits 1424 1340 -84
- Misses 43 49 +6
+ Partials 26 22 -4 ☔ View full report in Codecov by Sentry. |
nh13
reviewed
Jan 28, 2025
nh13
requested changes
Jan 28, 2025
znorgaard
force-pushed
the
zn_newer_pybwa
branch
from
c3c13ea to
016c7de
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
nh13
approved these changes
Jan 28, 2025
pyproject.toml
Outdated
| @@ -43,7 +43,7 @@ fgpyo = {git ="https://github.com/fulcrumgenomics/fgpyo" , rev= "c5eb469a4fbe4f2 | |||
| pysam = "^0.22.1" | |||
| ordered-set = "^4.1.0" | |||
| primer3-py = "^2.0.3" | |||
| pybwa = "1.3.3" | |||
| pybwa = "^1.3.3" | |||
There was a problem hiding this comment.
Might as well use the latest version
Suggested change
| pybwa = "^1.3.3" | |
| pybwa = "^1.4.4" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.