-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZipperBams to produce mate score ("ms") for samtools markdup #952
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
========================================
Coverage 95.62% 95.62%
========================================
Files 126 126
Lines 7354 7454 +100
Branches 502 491 -11
========================================
+ Hits 7032 7128 +96
- Misses 322 326 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't object in principal, but these should all probably be of the form:
primary.get[Int]("AS").foreach(supp("ms") = _)
so that it will work for aligners that don't produce an AS
tag and on pairs where only one read is aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but could you add/amend a couple of tests to make sure it works on both reads that have and don't have AS set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looks good to me
Fixes: #951