Add an entrypoint to SamSource for bytes of SAM/BAM/CRAM #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintval
commented
Jan 13, 2022
| * @param stringency the validation stringency to apply when reading the data | ||
| * @param factory a SAMRecordFactory; MUST return classes that mix in [[SamRecord]] | ||
| */ | ||
| def apply( |
There was a problem hiding this comment.
Unfortunately cannot set defaults here due to multiple apply overloadings.
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 114 114
Lines 6733 6740 +7
Branches 429 422 -7
=======================================
+ Hits 6428 6435 +7
Misses 305 305
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
clintval
force-pushed
the
cv_sam_source_bytes
branch
from
3854384 to
eeb9e83
Compare
|
Would you be willing to do a re-review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.