util.h - unmap region of block device #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RDWR mode, if file is a block device, like a SSD or ZVOL on ZFS, try to unmap the region on block device, using ioctl BLKDISCARD.
|
Please replace spaces with tabs. |
|
The changes contain only tabs, without spaces. |
|
Oops, my bad. |
Fixed a BIG bug in the code: ioctl.h does not included. No warnings when compile
Changed description for thin-provisioning, since block devices are supported.
fujita
reviewed
Nov 5, 2023
Enabled thin-provision option for discarding ranges from block devices, that supporting discard. If file is a block device, UNMAP command don't try a PUNCH HOLE in device, now it call ioctl BLKDISCARD.
|
squashed and pushed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RDWR mode, if file is a block device, like a SSD or ZVOL, try to unmap the region on block device, using ioctl BLKDISCARD.